Skip to content

Add support for ESP32-S2 arduino core version 2.0.0 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Sep 30, 2021
Merged

Add support for ESP32-S2 arduino core version 2.0.0 #126

merged 24 commits into from
Sep 30, 2021

Conversation

@hathach
Copy link
Member

@hathach hathach commented Sep 29, 2021 •
edited
Loading

  • Add support for ESP32-S2 core version 2.0.0, supercede Add support for TinyUSB Arduino Library espressif/arduino-esp32#5333

    • ESP32 port relies on Espressif's esp32-hal-tinyusb.c for building usb descriptors which requires all descriptors must be specified in usb objects declaration i.e constructors. Therefore all descriptor-related fields must be part of object declaration and descriptor-related API have no effect afterwards for this port.

  • Add new constructor for Adafruit_USBD_HID(desc_report, len, protocol, interval_ms, has_out_endpoint)

Note: Menu option USB CDC on Boot should be Enabled and Upload Mode should be Internal USB (if available).

Screenshot from 2021-09-29 22-05-38

@hathach
slightly modify stack to compile with esp32
29c1687
@hathach
update lib to compile with esp 2.0.0
4044e9a
@hathach
esp32s2 running well with lib API
611608f 
- Device and Serial (CDC) uses arduino-esp32 core code
- MSC work well using descriptor builder from core
@hathach
hid works with esp32 by moving arguments into constructor
0385061
@hathach
minor clean up
a6da6f2
@hathach
fine tune esp32 port
015735a
@hathach
change helper function signature a bit
fe9e880
@hathach
more clean up
7499bc3
@hathach
midi work with esp32
028058d
@hathach
esp32 work with webusb
7c20752
@hathach
update webusb example to support NEOPIXEL_POWER pin
1b22237
@hathach
update hid_boot_keyboard to support neopixel with power pin, button a…
335e90e 
…ctive high boards such as cpx, cpb and funhouse

also use built-in buttons if defined
@hathach
enable metro esp32s2 for ci
7bd22e6
@hathach
clang format
c63bf0e
@hathach
update hid composite to work with funhouse
41d45dd
@hathach
skip cdc_multi and no_serial for esp32s2
4a3013d
@hathach
update hid examples to work esp32s2
5e40ffd
@hathach
use ci-arduino with increased timeout
f5b5f05
@hathach
all hid examples work with esp32s2
0c5a29b
@hathach
all msc examples work with esp32s2, skip a couple of incompatible exa…
012db86 
…mples
@hathach
update note for esp32s2 port
c00c628
@hathach
update hid generic inout exmaple to work with esp32s2, update changelog
6eb5a28
@hathach
correct ci branch
3c612b5
@hathach hathach requested a review from ladyada September 29, 2021 14:21
@hathach hathach mentioned this pull request Sep 29, 2021
Closed
@brentru
Copy link
Member

brentru commented Sep 29, 2021

@hathach This is tested working with WipperSnapper Arduino with both ESP32-S2 and TinyUSB on SAMD51 (I'm staging changes on https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/tree/add-support-esp32-2.0)

@hathach
Copy link
Member Author

hathach commented Sep 30, 2021

thank you @brentru for testing this out. I think this PR is ready, we can merge and release it. Any issues can be fixed later on.

@hathach hathach merged commit 7438327 into master Sep 30, 2021
@hathach hathach deleted the support-esp32-2.0 branch September 30, 2021 06:08
This was referenced Oct 1, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ladyada ladyada Awaiting requested review from ladyada

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hathach @brentru